Skip to content

fix: preserve Google calendar selections across sync#4800

Open
ComputelessComputer wants to merge 1 commit intomainfrom
fix/google-calendar-checkbox-persistence
Open

fix: preserve Google calendar selections across sync#4800
ComputelessComputer wants to merge 1 commit intomainfrom
fix/google-calendar-checkbox-persistence

Conversation

@ComputelessComputer
Copy link
Copy Markdown
Collaborator

  • preserve enabled Google calendar selections when syncing legacy calendar rows that do not yet have a connection_id
  • migrate matched legacy rows onto the current connection instead of deleting and recreating them unchecked
  • add a regression test covering the legacy Google row case

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 28, 2026

Deploy Preview for char-cli-web canceled.

Name Link
🔨 Latest commit d273c5c
🔍 Latest deploy log https://app.netlify.com/projects/char-cli-web/deploys/69c7fbc47bcbaf0008c4fab2

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 28, 2026

Deploy Preview for hyprnote canceled.

Name Link
🔨 Latest commit d273c5c
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/69c7fbc42173550008bb9ec9

Copy link
Copy Markdown
Collaborator Author

Context on the issue this PR fixes:

I was seeing Google Calendar selections fail to stick in the desktop app. After checking a Google calendar in the Calendar sidebar, it would end up unchecked again after sync/reload even though the Google account was still connected.

This was most noticeable on older Google calendar rows that predated connection_id support. Sync treated those rows as new calendars, recreated them with enabled = false, and the checkbox appeared disabled/reset from the user perspective.

This PR preserves that enabled state and migrates the legacy row onto the current connection instead of replacing it.

@ComputelessComputer ComputelessComputer force-pushed the fix/google-calendar-checkbox-persistence branch from bd6a99a to d273c5c Compare March 28, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant